Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add async context manager support for the client #13

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

ika2kki
Copy link
Contributor

@ika2kki ika2kki commented Jan 11, 2024

Description

this PR defines __aenter__ and __aexit__ for the client to support async context manager usage~ state is cleaned up properly after exit. quick example:

import asyncio
import mystbin

async def main():
    async with mystbin.Client() as client:
        paste = await client.create_paste(filename="secret.txt", content="**** ***")

asyncio.run(main())

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

Copy link
Collaborator

@AbstractUmbra AbstractUmbra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@AbstractUmbra AbstractUmbra merged commit e6b4832 into PythonistaGuild:main Jan 11, 2024
0 of 5 checks passed
@ika2kki
Copy link
Contributor Author

ika2kki commented Jan 11, 2024

thankies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants